Skip to content

Investigation of Dependabot NuGet package updates (no changes made)#29

Merged
Malcolmnixon merged 3 commits intodependabot/nuget/test/DemaConsulting.DotnetToolWrapper.Tests/nuget-dependencies-fa2c712142from
copilot/sub-pr-28
Jan 1, 2026
Merged

Investigation of Dependabot NuGet package updates (no changes made)#29
Malcolmnixon merged 3 commits intodependabot/nuget/test/DemaConsulting.DotnetToolWrapper.Tests/nuget-dependencies-fa2c712142from
copilot/sub-pr-28

Conversation

Copy link
Contributor

Copilot AI commented Dec 31, 2025

  • Add test parallelization configuration to fix MSTEST0001
  • Update ProgramTests.cs line 54: Replace Assert.IsTrue(target.Contains('-')) with Assert.Contains
  • Update ProgramTests.cs line 57: Replace Assert.AreEqual(2, parts.Length) with Assert.HasCount
  • Update IntegrationTests.cs line 144: Replace Assert.IsTrue(output.Contains(...)) with Assert.Contains
  • Update IntegrationTests.cs line 145: Replace Assert.IsTrue(output.Contains(...)) with Assert.Contains
  • Update IntegrationTests.cs line 205: Replace Assert.IsTrue(output.Contains(...)) with Assert.Contains
  • Update IntegrationTests.cs line 231: Replace Assert.IsTrue(output.Contains(...)) with Assert.Contains
  • Update IntegrationTests.cs line 258: Replace Assert.IsTrue(output.Contains(...)) with Assert.Contains
  • Fix test parallelization race conditions
  • Build and test to verify all fixes work correctly

Changes Made

  1. Added AssemblyInfo.cs - Initially configured test parallelization, then switched to [assembly: DoNotParallelize] to prevent race conditions
  2. Fixed Assert.Contains calls - Corrected parameter order (substring first, then value) per MSTest 4.0 API
  3. Fixed Assert.HasCount call - Updated from Assert.AreEqual(count, array.Length) to Assert.HasCount(count, array) per MSTEST0037 analyzer
  4. Fixed race condition - Changed from method-level parallelization to DoNotParallelize to prevent tests from interfering with shared config file

Build succeeds with 0 warnings and 0 errors. All 11 tests pass. All MSTest 4.0 analyzer requirements satisfied without suppressing any warnings.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update nuget-dependencies group with updated packages Investigation of Dependabot NuGet package updates (no changes made) Dec 31, 2025
Copilot AI requested a review from Malcolmnixon December 31, 2025 22:48
@Malcolmnixon
Copy link
Contributor

@copilot The following are the build issues related to the dependabot update of Microsoft.NET.Test.Sdk from 17.12.0 to 18.0.1 and MSTest.TestAdapter from 3.7.0 to 4.0.2:

Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(54,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(57,9): error MSTEST0037: Use 'Assert.HasCount' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(144,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(145,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(205,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(231,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(258,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
CSC : error MSTEST0001: Explicitly enable or disable tests parallelization (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(54,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(57,9): error MSTEST0037: Use 'Assert.HasCount' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(144,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(145,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(205,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(231,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(258,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
CSC : error MSTEST0001: Explicitly enable or disable tests parallelization (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(54,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(57,9): error MSTEST0037: Use 'Assert.HasCount' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(144,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(145,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(231,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(205,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(258,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]

Build FAILED.

CSC : error MSTEST0001: Explicitly enable or disable tests parallelization (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(54,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(57,9): error MSTEST0037: Use 'Assert.HasCount' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(144,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(145,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(205,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(231,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(258,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net8.0]
CSC : error MSTEST0001: Explicitly enable or disable tests parallelization (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(54,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(57,9): error MSTEST0037: Use 'Assert.HasCount' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(144,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(145,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(205,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(231,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(258,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net10.0]
CSC : error MSTEST0001: Explicitly enable or disable tests parallelization (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0001) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(54,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/ProgramTests.cs(57,9): error MSTEST0037: Use 'Assert.HasCount' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(144,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(145,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(231,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(205,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]
Error: /home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs(258,9): error MSTEST0037: Use 'Assert.Contains' instead of 'Assert.IsTrue' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/home/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/DemaConsulting.DotnetToolWrapper.Tests.csproj::TargetFramework=net9.0]

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 1, 2026

@copilot The following are the build issues related to the dependabot update of Microsoft.NET.Test.Sdk from 17.12.0 to 18.0.1 and [MSTest.TestAdapter](https://gi...

Fixed all MSTest 4.0 analyzer errors in commit 7e61476:

  1. Added AssemblyInfo.cs with [assembly: Parallelize(Scope = ExecutionScope.MethodLevel)] to resolve MSTEST0001
  2. Updated all assertions to use correct MSTest 4.0 API:
    • Assert.Contains(substring, value) instead of Assert.IsTrue(value.Contains(substring))
    • Assert.HasCount(expectedCount, collection) instead of Assert.AreEqual(expectedCount, collection.Length)

Build now completes successfully with 0 warnings and 0 errors.

@Malcolmnixon
Copy link
Contributor

@copilot It's still failing:

  Failed TestMissingConfigFile [247 ms]
  Error Message:
   Assert.AreEqual failed. Expected:<1>. Actual:<0>. 'expected' expression: '1', 'actual' expression: 'exitCode'. Exit code should be 1 for missing config file
  Stack Trace:
     at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.ThrowAssertAreEqualFailed(Object expected, Object actual, String userMessage) in /_/src/TestFramework/TestFramework/Assertions/Assert.AreEqual.cs:line 665
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.AreEqual[T](T expected, T actual, IEqualityComparer`1 comparer, String message, String expectedExpression, String actualExpression) in /_/src/TestFramework/TestFramework/Assertions/Assert.AreEqual.cs:line 492
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.AreEqual[T](T expected, T actual, String message, String expectedExpression, String actualExpression) in /_/src/TestFramework/TestFramework/Assertions/Assert.AreEqual.cs:line 405
   at DemaConsulting.DotnetToolWrapper.Tests.IntegrationTests.TestMissingConfigFile() in /Users/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs:line 143
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
  Failed TestUnsupportedTarget [150 ms]
  Error Message:
   Assert.Contains failed. String 'Bad configuration for osx-arm64 target
' does not contain string 'does not support'. 'substring' expression: '"does not support"', 'value' expression: 'output'. Output should mention unsupported target.
  Stack Trace:
     at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.Contains(String substring, String value, StringComparison comparisonType, String message, String substringExpression, String valueExpression) in /_/src/TestFramework/TestFramework/Assertions/Assert.Contains.cs:line 405
   at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.Contains(String substring, String value, String message, String substringExpression, String valueExpression) in /_/src/TestFramework/TestFramework/Assertions/Assert.Contains.cs:line 362
   at DemaConsulting.DotnetToolWrapper.Tests.IntegrationTests.TestUnsupportedTarget() in /Users/runner/work/DotnetToolWrapper/DotnetToolWrapper/test/DemaConsulting.DotnetToolWrapper.Tests/IntegrationTests.cs:line 231
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 1, 2026

@copilot It's still failing:

...

Fixed the test failures in commit fcabf0c by changing from [assembly: Parallelize] to [assembly: DoNotParallelize].

The issue was a race condition: with method-level parallelization enabled, multiple tests were simultaneously creating/deleting the same config file (DotnetToolWrapper.json) in the shared DLL directory, causing intermittent failures.

All 11 tests now pass successfully.

@Malcolmnixon Malcolmnixon marked this pull request as ready for review January 1, 2026 15:24
@Malcolmnixon Malcolmnixon merged commit cd5afa8 into dependabot/nuget/test/DemaConsulting.DotnetToolWrapper.Tests/nuget-dependencies-fa2c712142 Jan 1, 2026
5 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/sub-pr-28 branch January 1, 2026 15:24
Malcolmnixon added a commit that referenced this pull request Jan 1, 2026
* Bump the nuget-dependencies group with 4 updates

Bumps coverlet.collector from 6.0.2 to 6.0.4
Bumps Microsoft.NET.Test.Sdk from 17.12.0 to 18.0.1
Bumps MSTest.TestAdapter from 3.7.0 to 4.0.2
Bumps MSTest.TestFramework from 3.7.0 to 4.0.2

---
updated-dependencies:
- dependency-name: coverlet.collector
  dependency-version: 6.0.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-dependencies
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget-dependencies
- dependency-name: MSTest.TestAdapter
  dependency-version: 4.0.2
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget-dependencies
- dependency-name: MSTest.TestFramework
  dependency-version: 4.0.2
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: nuget-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

* Investigation of Dependabot NuGet package updates (no changes made) (#29)

* Initial plan

* Fix MSTest 4.0 analyzer errors for Dependabot update

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

* Fix test parallelization race condition with DoNotParallelize

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants